Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Miscellaneous improvements to the proofreading tool #6477

Merged
merged 8 commits into from
Sep 21, 2022

Conversation

philippotto
Copy link
Member

@philippotto philippotto commented Sep 16, 2022

  • fix race condition in conflict-checking code by re-reading current version from store
  • use base mapping name of editable mapping in mapping UI if possible
  • don't try to load agglomerate skeleton if user selects a node in proofreading tool (this could load another skeleton if a node was only visible due to a high clipping distance which was confusing)

URL of deployed dev instance (used for testing):

  • https://___.webknossos.xyz

Steps to test:

  • open DS with agglomerate mapping and select it
  • select proofreading tool and use click on a segment
  • the left sidebar should show a readable name for the mapping
  • select a node in the tree --> nothing else should happen

Issues:


(Please delete unneeded items, merge only when none are left open)

@philippotto philippotto self-assigned this Sep 16, 2022
Copy link
Member

@hotzenklotz hotzenklotz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@philippotto philippotto marked this pull request as ready for review September 21, 2022 08:23
@philippotto philippotto merged commit b58497e into master Sep 21, 2022
@philippotto philippotto deleted the proofreading-misc-fixes branch September 21, 2022 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants